change TopologyConstraint.TopologyName to optional#601
Merged
Conversation
enoodle
requested review from
Ronkahn21,
danbar2,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
enoodle
force-pushed
the
erez/optional-topology-name
branch
from
abcf0a1 to
a41825b
Compare
danbar2
reviewed
May 12, 2026
danbar2
reviewed
May 12, 2026
danbar2
previously approved these changes
May 12, 2026
shayasoolin
reviewed
May 18, 2026
enoodle
force-pushed
the
erez/optional-topology-name
branch
from
34f7661 to
307e2b3
Compare
danbar2
previously approved these changes
May 19, 2026
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
enoodle
force-pushed
the
erez/optional-topology-name
branch
from
307e2b3 to
3b65a1d
Compare
shayasoolin
approved these changes
May 20, 2026
danbar2
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #582
Special notes for your reviewer:
This is in continuation to the changes made in #496 - We update this field to have a more precise API that will be more flexible in the future.
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: